Skip to content

[O2B-1509] LHCfills scheme name filter #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Houwie7000 wants to merge 10 commits into
base: feature/O2B-1508/lhcfills-beam-types-filter
Choose a base branch
from
Open

[O2B-1509] LHCfills scheme name filter #2046

Houwie7000 wants to merge 10 commits into from
+123 −2

Conversation

@Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Dec 16, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHCfills page now has a scheme name filter

Notable changes for developers:

Changes made to the database:

@Houwie7000 Houwie7000 self-assigned this Dec 16, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.68%. Comparing base (475c273) to head (e000151).
⚠️ Report is 2 commits behind head on feature/O2B-1508/lhcfills-beam-types-filter.

Files with missing lines Patch % Lines
...ponents/Filters/LhcFillsFilter/schemeNameFilter.js 0.00% 1 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                               Coverage Diff                               @@
##           feature/O2B-1508/lhcfills-beam-types-filter    #2046      +/-   ##
===============================================================================
- Coverage                                        45.71%   45.68%   -0.03%     
===============================================================================
  Files                                             1039     1040       +1     
  Lines                                            17263    17254       -9     
  Branches                                          3142     3135       -7     
===============================================================================
- Hits                                              7891     7882       -9     
  Misses                                            9372     9372

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1508/lhcfills-beam-types-filter branch from ac739fe to 475c273 Compare January 22, 2026 16:16
@Houwie7000
Copy link
Collaborator Author

Houwie7000 commented Jan 22, 2026 •
edited
Loading

push -f is a correction of the push -f in 1508...

@Houwie7000 Houwie7000 marked this pull request as ready for review January 22, 2026 16:29
@Houwie7000 Houwie7000 requested a review from graduta as a code owner January 22, 2026 16:29
isaachilly
isaachilly reviewed Jan 25, 2026
View reviewed changes
Copy link
Collaborator

@isaachilly isaachilly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the small issues mentioned in the comments

@isaachilly
[O2B-1509] Update 'schemename' to 'scheme name' in tests
5737c58 
Renamed occurrences of 'schemename' to 'scheme name' in test descriptions and variable names for consistency.
@isaachilly
[O2B-1509] Update scheme name filter class and related tests
e000151 
Removed 'scheme-name-filter' class from the scheme name filter component and updated test selectors to use '.fillingSchemeName-filter input' instead so as not to use a class as essentially an ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaachilly isaachilly isaachilly approved these changes

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@Houwie7000 Houwie7000

Labels

backend frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Houwie7000 @isaachilly